Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove wrapping to new line on social pill #2054

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Oct 30, 2023

Summary of Changes

Adding a hyphen in the social pill is causing it to wrap to a new line, which is not desired

Demo or Before/After Pics

Before After
Screenshot 2023-10-31 at 1 18 26 AM Screenshot 2023-10-31 at 1 18 26 AM

Edge Cases

Tested different special character in the username

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@Rohan-cp Rohan-cp requested a review from Robinnnnn October 30, 2023 19:50
@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 7:51pm

@github-actions
Copy link

Bundle Sizes

Compared against 5255e6f

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit 72875c0 into main Oct 31, 2023
6 checks passed
@Robinnnnn Robinnnnn deleted the rohan/minor-social-pill-style branch October 31, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants